On Fri, Mar 26, 2010 at 09:26:14AM +0100, Fred Kiefer wrote: > I only had a short look at this patch and was a bit surprised to see how > little these two implementations share. In a normal class cluster you > would expect that most of the code is in the common super class and only > the primitive methods get implemented separately. What was the reason > for doing it differently here? Even the delegate handling methods are > duplicated, with the mDNS ones having an additional tracing call. > Apart from that your patch makes perfectly sense to me. > > Fred > > PS: You seem to be using tabs to indent your code. Spaces (two of them > actually) are prefered.
All ammended (including indentation) and available from the locations previously announced [0,1]. But I understand you won't be wanting to apply this until after the proposed release… Cheers, Niels -- [0] http://www.halbordnung.de/~thebeing/gnustep/NSNetServices+avahi.patch [1] http://review.etoileos.com/r/137/
signature.asc
Description: Digital signature
_______________________________________________ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
