Hi,
the check was taken out to avoid exactly the error you was getting,
although at a different line. I checked the test on several machines
with different OSs and architectures and it worked perfectly (gentoo,
debian, OpenBSD, FreeBSD...)
The header of the library says exactly:
/* This is an attempt to force a single setjmp behaviour on Linux. If
* the X config stuff didn't define _BSD_SOURCE we wouldn't need this.
*
* You can bypass this test if you know that your application uses exactly
* the same setjmp.h that was included when libpng was built. Only define
* PNG_SKIP_SETJMP_CHECK while building your application, prior to the
* application's '#include "png.h"'. Don't define PNG_SKIP_SETJMP_CHECK
* while building a separate libpng library for general use.
*/
Interestingly, now that you backed out the change again, it still works
for me on a first quick test. Perhaps something else changed in the
header import order? I just verified on my 3 fastest computer this
evening and it appears to work, but it really makes me wonder.
Base imports setjmp in NSException and in NSDebug. I don't see recent
changes there.
Riccardo
Gregory Casamento wrote:
2010-05-25 Riccardo Mottola<[email protected]>
* Source/NSBitmapImageRep+PNG.m
Skip libpng's check for setjmp. I hope we are indeed correct.
I'm wondering why the check for setjmp was taken out.
GC
On Sat, May 29, 2010 at 1:10 AM, Gregory Casamento
<[email protected]> wrote:
Compiling file NSBitmapImageRep+PNG.m ...
In file included from /usr/include/libpng/png.h:438,
from NSBitmapImageRep+PNG.m:42:
/usr/include/libpng/pngconf.h:326: error: expected ‘=’, ‘,’,
‘;’, ‘asm’ or ‘__attribute__’ before ‘.’ token
/usr/include/libpng/pngconf.h:327: error: expected ‘=’, ‘,’,
‘;’, ‘asm’ or ‘__attribute__’ before ‘include’
make[4]: *** [obj/libgnustep-gui.obj/NSBitmapImageRep+PNG.m.o] Error 1
make[3]: *** [internal-library-all_] Error 2
make[2]: *** [libgnustep-gui.all.library.variables] Error 2
make[1]: *** [internal-all] Error 2
make: *** [internal-all] Error 2
--
Gregory Casamento - GNUstep Lead/Principal Consultant, OLC, Inc.
yahoo/skype: greg_casamento, aol: gjcasa
(240)274-9630 (Cell)
_______________________________________________
Gnustep-dev mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/gnustep-dev
