Should I put in error handling for this case and issue a warning if this happens when using ICU? It seems wrong not to check for an error condition in this case.
I'd like to find out why this is happening in the first place. I found it while testing the new Cairo changes, but it doesn't seem like this would be backend specific. I tested with both backends just to be sure and I get the same results. GC On Tue, Nov 27, 2012 at 9:47 AM, Richard Frith-Macdonald < [email protected]> wrote: > > On 27 Nov 2012, at 13:57, Gregory Casamento wrote: > > > Hey guys, > > > > I am having a problem starting up Gorm on Windows. I have traced it to > this section of code in NSDateFormatter... > > > > 125 > > 126 length = udat_toPattern (internal->_formatter, 0, NULL, 0, > &err); > > 127 value = NSZoneMalloc (z, sizeof(unichar) * length); > > 128 err = U_ZERO_ERROR; > > 129 udat_toPattern (internal->_formatter, 0, value, length, > &err); > > > > The issue is that length is coming back as -1, which, when the > NSZoneMalloc tries to allocate ends up trying to allocate all available > memory since the value is interpreted as unsigned. > > > > The only reason Gorm gets this issue and the other apps I tested don't > is due to the fact that none of the others attempt to use NSDateFormatter. > > I know nothing about this code directly, but I had a little look anyway: > > All the documentation I can find online says that udat_toPattern() should > return a length ... so this problem shouldn't happen. > But I guess it's returning -1 as an error condition of some sort ... just > looking at it I'd guess the problem must be incorrect initialisation of > internal->_formatter. > So I'd recommend you try looking for a problem earlier on, to do wioth > initialisation of the formatter. -- Gregory Casamento Open Logic Corporation, Principal Consultant yahoo/skype: greg_casamento, aol: gjcasa (240)274-9630 (Cell) http://www.gnustep.org http://heronsperch.blogspot.com
_______________________________________________ Gnustep-dev mailing list [email protected] https://lists.gnu.org/mailman/listinfo/gnustep-dev
