Hi Philippe, Sorry for taking so long - I just applied your patches, they look good.
Thanks, Eric On 2013-09-27, at 10:59 AM, Philippe Roussel <[email protected]> wrote: > Hi Ivan, > > You seem to be working on opal, could you take a look at the following ? > > Philippe > > On Thu, Sep 19, 2013 at 07:21:40AM +0200, Philippe Roussel wrote: >> Hi, >> >> Scanning opal build warnings I found at least 2 that look like real >> bugs, see the following patch. >> >> Philippe >> >> Index: Source/OpalGraphics/CGImage.m >> =================================================================== >> --- Source/OpalGraphics/CGImage.m (révision 37110) >> +++ Source/OpalGraphics/CGImage.m (copie de travail) >> @@ -158,7 +158,7 @@ >> self->surf = NULL; >> self->bitmapInfo = aBitmapInfo; >> self->cspace = CGColorSpaceRetain(aColorspace); >> - self->intent = intent; >> + self->intent = anIntent; >> >> return self; >> } >> Index: Source/OpalText/CTLine.m >> =================================================================== >> --- Source/OpalText/CTLine.m (révision 37110) >> +++ Source/OpalText/CTLine.m (copie de travail) >> @@ -30,7 +30,7 @@ >> >> - (id)initWithRuns: (NSArray*)runs >> { >> - if ((self == [super init])) >> + if ((self = [super init])) >> { >> _runs = [runs retain]; >> } >> >> -- >> Letting the Internet be rewired by bureaucrats would be like handing a >> Stradivarius to a gorilla. L. Gordon Crovitz > > _______________________________________________ > Gnustep-dev mailing list > [email protected] > https://lists.gnu.org/mailman/listinfo/gnustep-dev _______________________________________________ Gnustep-dev mailing list [email protected] https://lists.gnu.org/mailman/listinfo/gnustep-dev
