So I tested this some more, and after rebuilding libs-base as a whole (I had previously only rebuilt the relevant files) I’m getting the following linker errors:
> lld-link: error: <root>: undefined symbol: Q^?LL} > lld-link: error: <root>: undefined symbol: ^{autorelease_array_list}II[0☺]} > lld-link: error: <root>: undefined symbol: > ^{_NSZone}QQ^{_GSIMapBucket}^{_GSIMapNode}Q^^{_GSIMapNode}Q} > lld-link: error: <root>: undefined symbol: ciiC[38C]} > lld-link: error: <root>: undefined symbol: {_RTL_SRWLOCK=^v}ALIi} > lld-link: error: <root>: undefined symbol: ^v} > lld-link: error: <root>: undefined symbol: ^?^?^?^?^?^?^?Q☺^{_NSZone}} > lld-link: error: <root>: undefined symbol: > ^{_NSNotificationQueueRegistration}^{_NSNotificationQueueRegistration}} > lld-link: error: <root>: undefined symbol: ☺I^☺ii} > lld-link: error: <root>: undefined symbol: i☺☺} > lld-link: error: <root>: undefined symbol: > [16{_SETJMP_FLOAT128=[2Q]}]^{_NSHandler}☺} > lld-link: error: <root>: undefined symbol: QQ} > lld-link: error: <root>: undefined symbol: > ^{_xmlDoc}^{_xmlDtd}^{_xmlEntity}^{_xmlNode}) > lld-link: error: <root>: undefined symbol: ☺☺{?=b0I1b1I31}} > lld-link: error: <root>: undefined symbol: > b0I1b1I1b2I1b3I1b4I1b5I1b6I1b7I1b8I1} I’m not sure if they indicate an issue with the patch, or if it’s rather an issue e.g. with how I built Clang or how I’m using the custom build? I used the LLVM_ENABLE_PROJECTS=clang CMake option to build Clang, but maybe I need to enable other LLVM projects like lld, libcxx or others too? Thanks, Frederik > Am 25.10.2021 um 17:42 schrieb David Chisnall <gnus...@theravensnest.org>: > > Hi, > > If you can comment on the review and approve it, I can commit it (once I’ve > fixed the clangformat warnings). > > David > >> On 23 Oct 2021, at 16:33, Frederik Seiffert <frede...@algoriddim.com> wrote: >> >> Hi David, >> >>> Am 14.10.2021 um 13:59 schrieb David Chisnall <gnus...@theravensnest.org>: >>> >>> I believe this patch should fix it: >>> >>> https://reviews.llvm.org/D111792 >> >> Thank you, this worked great after I built Clang 13 with this patch applied! >> >> What’s the process for getting this merged, and and any idea when we could >> expect official builds with it? >> >> Frederik >> >> >