Daiki Ueno created a merge request:
https://gitlab.com/gnutls/gnutls/-/merge_requests/1975
Project:Branches: dueno/gnutls:wip/dueno/pkcs11-provider-fixes to
gnutls/gnutls:master
Author: Daiki Ueno
Reviewer: Zoltán Fridrich
<!-- Add a description of the new feature/bug fix. Reference any relevant bugs.
-->
* build: fix build with --with-included-libtasn1
As libminitasn1.la is always built a static library, linking it twice
makes linking fail because of duplicated symbols.
* pkcs11: stop including <nettle/bignum.h>
The header is unused and causing compile error on macOS homebrew:
```
In file included from p11_pk.c:32:
/opt/homebrew/Cellar/nettle/3.10.2/include/nettle/bignum.h:50:11: fatal
error: 'gmp.h' file not found
# include <gmp.h>
^~~~~~~
1 error generated.
```
## Checklist
* [x] Commits have `Signed-off-by:` with name/author being identical to the
commit author
* [ ] Code modified for feature
* [ ] Test suite updated with functionality tests
* [ ] Test suite updated with negative tests
* [ ] Documentation updated / NEWS entry present (for non-trivial changes)
* [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)
## Reviewer's checklist:
* [ ] Any issues marked for closing are addressed
* [ ] There is a test suite reasonably covering new functionality or
modifications
* [ ] Function naming, parameters, return values, types, etc., are consistent
and according to `CONTRIBUTION.md`
* [ ] This feature/change has adequate documentation added
* [ ] No obvious mistakes in the code
--
Reply to this email directly or view it on GitLab:
https://gitlab.com/gnutls/gnutls/-/merge_requests/1975
You're receiving this email because of your account on gitlab.com.
_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@lists.gnutls.org
http://lists.gnupg.org/mailman/listinfo/gnutls-devel
