Sam James started a new discussion on tests/system-override-compress-cert.sh: 
https://gitlab.com/gnutls/gnutls/-/merge_requests/1980#note_2623065262

 >      exit 77
 >  fi
 >  
 > +if ! "$CLI" --list | grep '^Compression: .*COMP-\(BROTLI\|ZSTD\)'; then

I see a failure on one machine with your patch applied where I built gnutls 
with zlib, zstd, but not brotli:
```
FAIL: system-override-compress-cert                                             
                                                                                
           |
===================================                                             
                                                                                
           |
                                                                                
                                                                                
           |
Compression: COMP-NULL, COMP-ZLIB, COMP-ZSTD                                    
                                                                                
           |
./compress-cert-conf expected to succeed                                        
                                                                                
           |
FAIL system-override-compress-cert.sh (exit status: 1)  
```

I think the grep just checks for _either_ BROTLI or _ZSTD_, it doesn't require 
both?

On another machine where I had zlib but not zstd or brotli, it failed before 
your patch, and works with it.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnutls/gnutls/-/merge_requests/1980#note_2623065262
You're receiving this email because of your account on gitlab.com.


_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@lists.gnutls.org
http://lists.gnupg.org/mailman/listinfo/gnutls-devel
  • Re: [gnutl... Read-only notification of GnuTLS library development activities
    • Re: [... Read-only notification of GnuTLS library development activities
    • [gnut... Read-only notification of GnuTLS library development activities
    • Re: [... Read-only notification of GnuTLS library development activities
    • Re: [... Read-only notification of GnuTLS library development activities
    • Re: [... Read-only notification of GnuTLS library development activities
    • Re: [... Read-only notification of GnuTLS library development activities
    • Re: [... Read-only notification of GnuTLS library development activities
    • Re: [... Read-only notification of GnuTLS library development activities
    • Re: [... Read-only notification of GnuTLS library development activities
    • Re: [... Read-only notification of GnuTLS library development activities
    • Re: [... Read-only notification of GnuTLS library development activities
    • Re: [... Read-only notification of GnuTLS library development activities

Reply via email to