Daiki Ueno commented: 
https://gitlab.com/gnutls/gnutls/-/merge_requests/1965#note_2694361769


Thank you for the update. Feature wise, this looks fine to me, though I would 
like to see a unit test covering this function - maybe you could modify 
tests/handshake-write.c to update keys on both server and client, and ensure 
they can still transfer data with each other.

It's also tempting to remove "trigger" from the function name, as it doesn't 
trigger but just updates the receiving key. Maybe 
`gnutls_handshake_update_receiving_key`?

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnutls/gnutls/-/merge_requests/1965#note_2694361769
You're receiving this email because of your account on gitlab.com.


_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@lists.gnutls.org
http://lists.gnupg.org/mailman/listinfo/gnutls-devel
  • [gnutls-de... Read-only notification of GnuTLS library development activities
    • Re: [... Read-only notification of GnuTLS library development activities
    • Re: [... Read-only notification of GnuTLS library development activities
    • Re: [... Read-only notification of GnuTLS library development activities
    • Re: [... Read-only notification of GnuTLS library development activities
    • Re: [... Read-only notification of GnuTLS library development activities
    • Re: [... Read-only notification of GnuTLS library development activities
    • Re: [... Read-only notification of GnuTLS library development activities
    • Re: [... Read-only notification of GnuTLS library development activities

Reply via email to