Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/2018 was reviewed by Alexander Sosedkin
-- Alexander Sosedkin started a new discussion on lib/pkcs11/p11_mac.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2018#note_2758535896 > > - params.bExtract = CK_TRUE; > + params.bExtract = true; these attrnames are guarded by `CRYPTOKI_COMPAT`, which are supposed to be disabled by `CRYPTOKI_GNU`, unless specifically enabled back... how do they work? were they supposed to be changed to non-compat ones? -- Alexander Sosedkin started a new discussion on doc/cha-config.texi: https://gitlab.com/gnutls/gnutls/-/merge_requests/2018#note_2758535908 > @itemize > -@item @code{path}: path to the PKCS#11 module. > +@item @code{url}: URL of the PKCS#11 module. if we need to support both names, we might need tests for that. if we can drop support for the old name, we need to be louder about the breakage, since that went into 3.8.10 -- Alexander Sosedkin started a new discussion on tests/pkcs11-provider/test-pkcs11-provider.sh: https://gitlab.com/gnutls/gnutls/-/merge_requests/2018#note_2758535917 > [provider] > -path = ${MODULE} > +url = pkcs11:model=v1;manufacturer=Kryoptic%20Project;token=Kryoptic%20Token I guess a CI job that exercises it is overdue -- Alexander Sosedkin started a new discussion on tests/pkcs11-provider/test-pkcs11-provider.sh: https://gitlab.com/gnutls/gnutls/-/merge_requests/2018#note_2758535923 > -KRYOPTIC_DB="${testdir}/kryoptic.$$.sql" > -export KRYOPTIC_CONF="${testdir}/kryoptic.$$.conf" > +PRIORITY_FILE="${testdir}/gnutls.conf" why drop `$$`, if the testdir is not test-unique? or does it depend on no other tests using gnutls.conf? -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2018 You're receiving this email because of your account on gitlab.com.
_______________________________________________ Gnutls-devel mailing list Gnutls-devel@lists.gnutls.org http://lists.gnupg.org/mailman/listinfo/gnutls-devel
