On April 30, 2014 at 2:45 PM Daniel Kahn Gillmor <[email protected]> wrote: > On 04/30/2014 02:37 PM, dev wrote: > > cause : > > > > "x509.c", line 2894: warning: argument #3 is incompatible with > > prototype: > > prototype: pointer to unsigned int : > > "./../includes/gnutls/x509-ext.h", line 64 > > argument : pointer to enum gnutls_x509_subject_alt_name_t > > {GNUTLS_SAN_OTHERNAME_XMPP(1000), GNUTLS_SAN_DN(6), > > GNUTLS_SAN_OTHERNAME(5), GNUTLS_SAN_IPADDRESS(4), GNUTLS_SAN_URI(3), > > GNUTLS_SAN_RFC822NAME(2), GNUTLS_SAN_DNSNAME(1)} > > thanks for your code cleanup efforts, dev! > > can you please send future patches in unified diff format (diff -u) > instead of the old-style diff format? unified diffs are more stable > and > give a bit more context to the reader.
Sorry. What is the standard in the code for indents? I see tabs and spaces and if I make a change I will try to keep the line to 72 char or less in length and generally indent with spaces but I see a mixture of both. Also when I run into little things like this : CCLD libgnutls-openssl.la Undefined first referenced symbol in file nanosleep .libs/gnutls_openssl.o (symbol belongs to implicit dependency /lib/64/librt.so.1) ld: fatal: symbol referencing errors. No output written to .libs/libgnutls-openssl.so.27.0.2 gmake[3]: *** [libgnutls-openssl.la] Error 2 I know that the fix won't be in the code because nanosleep on Solaris needs -lrt in the link stage and I have to hack Makefile like so : $ diff -u extra/Makefile.backup extra/Makefile --- extra/Makefile.backup Wed Apr 30 18:32:45 2014 +++ extra/Makefile Wed Apr 30 18:56:41 2014 @@ -976,7 +976,7 @@ LIBPTHREAD_PREFIX = LIBRT = -lrt LIBRT_PREFIX = -LIBS = -lintl -lgen +LIBS = -lintl -lgen -lrt LIBSOCKET = -lsocket LIBTASN1_CFLAGS = LIBTASN1_LIBS = So that isn't a code change and so not sure how to help with that. However things like this I can fix : gmake[4]: Entering directory `/usr/local/build/gnutls-3.3.1_SunOS5.10_sparcv9_001/src/libopts' CC libopts_la-libopts.lo "./compat/compat.h", line 188: error: invalid type combination "./compat/compat.h", line 188: warning: typedef declares no type name cc: acomp failed for libopts.c gmake[4]: *** [libopts_la-libopts.lo] Error 1 gmake[4]: Leaving directory `/usr/local/build/gnutls-3.3.1_SunOS5.10_sparcv9_001/src/libopts' I'll use diff -u and just mail them in. dev _______________________________________________ Gnutls-help mailing list [email protected] http://lists.gnupg.org/mailman/listinfo/gnutls-help
