Hi Iwase If I understand your implementation correctly, you are assigning unique label per VRF, right? If so, your implementation looks good to me. Thanks for working on it.
thx aman -----Original Message----- From: Iwase Yusuke [mailto:iwase.yusu...@gmail.com] Sent: Monday, January 29, 2018 2:04 AM To: SHAIKH, AMAN (AMAN) <asha...@research.att.com> Cc: gobgp-devel@lists.sourceforge.net Subject: Re: [GoBGP-devel] MPLS label issue with VPNv4 routes Hi Aman, As on my previous mail, sorry I don't know why this PR was not accepted... But, your suggestion is reasonable to me. How about the following patches? https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_osrg_gobgp_compare_master...iwaseyusuke-3Aserver-2DAuto-5FMPLS-5Flabel-5Fassignment-5Fon-5FVRF&d=DwIDaQ&c=LFYZ-o9_HUMeMTSQicvjIg&r=I_2UmL83HQfOEoCVzChS_fiJdy8vxHF4_JM0AhcKK4Y&m=uOXE6ZudpknHhEEmiZtyfRTfpp97zu4uw1FHolrQsvE&s=qsl4D_4GUltpZxcK-qSFyXzhPFP-OuOD7c_1fjTt93Q&e= The first patch does not directly fix this issue, but is convenient to update neighbor settings, and with the second one, you can configure VRF like; # Configure VRFs on router "10.0.0.1" (r1) r1> gobgp vrf add blue rd 65000:100 rt both 65000:100 gobgp vrf add red r1> rd 65000:200 rt both 65000:200 gobgp neighbor update 10.0.0.2 vrf r1> blue gobgp neighbor update 10.0.0.3 vrf red # Add a prefix on router "10.0.0.2" (r2) r2> gobgp global rib -a ipv4 add 192.168.1.0/24 gobgp global rib -a ipv4 Network Next Hop AS_PATH Age Attrs *> 192.168.1.0/24 0.0.0.0 00:00:00 [{Origin: ?}] # Add the same prefix on router "10.0.0.3" (r3) r3> gobgp global rib -a ipv4 add 192.168.1.0/24 gobgp global rib -a ipv4 Network Next Hop AS_PATH Age Attrs *> 192.168.1.0/24 0.0.0.0 00:00:00 [{Origin: ?}] # Show VPN routes on r1 r1> gobgp global rib -a vpnv4 Network Labels Next Hop AS_PATH Age Attrs *> 65000:100:192.168.1.0/24 [1000] 10.0.0.2 00:00:00 [{Origin: ?} {LocalPref: 100} {Extcomms: [65000:100]}] *> 65000:200:192.168.1.0/24 [1001] 10.0.0.3 00:00:00 [{Origin: ?} {LocalPref: 100} {Extcomms: [65000:200]}] Thanks, Iwase On 2018年01月27日 06:28, SHAIKH, AMAN (AMAN) wrote: > Hi Iwase > > --> I looked at the PR in some detail. Seems quite reasonable to me in terms > of changes. Do you know the reason why it was not accepted? > > FYI, the auto assignment feature seems to be posted, but not merged. > (sorry, I don't know why...) > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_osrg_g > obgp_pull_366&d=DwIDaQ&c=LFYZ-o9_HUMeMTSQicvjIg&r=I_2UmL83HQfOEoCVzChS > _fiJdy8vxHF4_JM0AhcKK4Y&m=XsNqliUbM-wXJ4BIRg17Ql3I4zlbKtrslZXuwiiSSj0& > s=BuzaMx-UPDZUk8TQkyyyrRJMDX5faq5YG3mVHMetuLs&e= > > thx > aman > ---------------------------------------------------------------------- > -------- Check out the vibrant tech community on one of the world's > most engaging tech sites, Slashdot.org! > https://urldefense.proofpoint.com/v2/url?u=http-3A__sdm.link_slashdot&; > d=DwIDaQ&c=LFYZ-o9_HUMeMTSQicvjIg&r=I_2UmL83HQfOEoCVzChS_fiJdy8vxHF4_J > M0AhcKK4Y&m=uOXE6ZudpknHhEEmiZtyfRTfpp97zu4uw1FHolrQsvE&s=eZDjC_yPHml7 > mnCXzvwOf7LiJXt4vCh4IB0aSwK4Jv8&e= > _______________________________________________ > gobgp-devel mailing list > gobgp-devel@lists.sourceforge.net > https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.sourceforge > .net_lists_listinfo_gobgp-2Ddevel&d=DwIDaQ&c=LFYZ-o9_HUMeMTSQicvjIg&r= > I_2UmL83HQfOEoCVzChS_fiJdy8vxHF4_JM0AhcKK4Y&m=uOXE6ZudpknHhEEmiZtyfRTf > pp97zu4uw1FHolrQsvE&s=K-4idAXo8DrEumuFj2k2eqUKUqdpaVIQCOk1vyfLbX0&e= > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ gobgp-devel mailing list gobgp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/gobgp-devel
