On 7/21/06, André Detsch <[EMAIL PROTECTED]> wrote:
CVSROOT:        /sources/goboscripts
Module name:    tools
Changes by:     André Detsch <detsch>   06/07/22 02:32:02

Modified files:
        BuildLiveCD/bin: BuildRoot ChrootEnvironment CompressAndBuildISO
                         MakeInitRDTree MakeSystemSettings
                         UpdateEnvironment
Removed files:
        BuildLiveCD/Resources/Defaults/Settings/BuildLiveCD: Master.conf


RCS file: /sources/goboscripts/tools/BuildLiveCD/bin/CompressAndBuildISO,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -b -r1.25 -r1.26
--- bin/CompressAndBuildISO     17 Jul 2006 00:14:56 -0000      1.25
+++ bin/CompressAndBuildISO     22 Jul 2006 02:32:02 -0000      1.26

-datadir="/Programs/BuildLiveCD/Current/Data"
-tools=`cat $datadir/Packages-List-GoboLinuxTools`
-today=`date +%Y%m%d`
-arch=`uname -m`

 root=$PWD
-localcvs=$PWD/LocalCVS/
-packages=$PWD/Archives/Packages
-externalarchives=$PWD/Archives/Ext
-external=$PWD/External
+kernel_version=`sed -n 's,.*--\(.*\)--kernel.*,\1,p' 
/Programs/BuildLiveCD/Current/Data/Packages-Devel-i686`
+arch=i686

Is there any special reason to replace `uname -m` by a hardcoded i686
entry? Does the AMD64 return something different? While the ISO is
still focused on i686, I think it's nice to develop taking care of
these little "portability" details (just thinking about some possible
PPC efforts).

===================================================================
RCS file: /sources/goboscripts/tools/BuildLiveCD/bin/MakeInitRDTree,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -b -r1.10 -r1.11
--- bin/MakeInitRDTree  11 Jul 2006 14:53:37 -0000      1.10
+++ bin/MakeInitRDTree  22 Jul 2006 02:32:02 -0000      1.11
@@ -23,7 +23,6 @@
 rm -rf $root

 mkdir -p $root
-mkdir -p $archives

 ####################################################
 # Fetch packages
@@ -49,7 +48,7 @@
 mkdir -p $root/Mount/HD1
 mkdir -p $root/Mount/HD2
 mkdir -p $root/Mount/Floppy
-mkdir -p $root/Mount/Pivot
+mkdir -p $root/Mount/Pivot # is this needed?

It doesn't seem to be necessary. The only Pivot entry being used it
$root/Mount/.Pivot, which is being created by BuildRoot:

[EMAIL PROTECTED] ~/tools] g -r pivot
BuildLiveCD/bin/MakeInitRDTree:51:mkdir -p $root/Mount/Pivot # is this needed?
BuildLiveCD/bin/BuildRoot:211:create_dir $root/Mount/.Pivot
InitRDScripts/bin/startGoboLinux:36:echo "Performing pivot_root..."
InitRDScripts/bin/startGoboLinux:38:/bin/pivot_root . Mount/.Pivot
Scripts/bin/mkinitrd.pl:183:pivot_root . initrd

BTW, thanks for the big cleanup. Good job! :)

--
Lucas
powered by /dev/dsp
_______________________________________________
gobolinux-devel mailing list
gobolinux-devel@lists.gobolinux.org
http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel

Reply via email to