On Tue, 05 Dec 2006 04:09:55 +0100, Lucas C. Villa Real  
<[EMAIL PROTECTED]> wrote:

> On 12/4/06, Jonas Karlsson <[EMAIL PROTECTED]> wrote:
>> -chrootcompileMode="gobo"
>> -[ -e "./Compile.conf" ] && chrootcompileCompileConf="./Compile.conf"
>> -
>> +Parse_Conf Compile.conf
>>  # allows one to override any of the above variables
>> -[ -e "./ChrootCompile.conf" ] && source "./ChrootCompile.conf"
>> +Parse_Conf --mandatory ChrootCompile.conf
>
> ChrootCompile.conf should be optional, there's no need to use  
> --mandatory here.
>
It slipped in. I used --mandatory as debug...

>> +Is_Entry "use-directory" && chrootCompileDir="$(Entry 'use-directory')"
>>
>>  if [ "$UID" -ne 0 ]
>>  then sudo=sudo
>> @@ -80,16 +81,32 @@
>>  unset verbose
>>  Boolean "verbose" && verbose="--verbose"
>>
>> -
>>  
>> #############################################################################
>>  # Verify our whereabouts
>>  
>> #############################################################################
>>  if [ ! -d BaseDependencies -a ! "$local_programs" ]
>>  then
>>     if [ ! -z "`ls`" ]
>> -   then Die "This doesn't look like a ChrootCompile environment  
>> directory. Rerun this script on an empty directory to build an  
>> environment."
>> +   then
>> +      if [ ! -z "${chrootCompileDir}" ]
>> +      then
>> +         cd "${chrootCompileDir}"
>
> I would suggest to use 'Quiet pushd' (and to add the missing 'Quiet
> popd' afterwards).
>
I'll do that :)

-- 
/Jonas

Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
_______________________________________________
gobolinux-devel mailing list
gobolinux-devel@lists.gobolinux.org
http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel

Reply via email to