On 3/8/07, Jonas Karlsson <[EMAIL PROTECTED]> wrote: > CVSROOT: /sources/goboscripts > Module name: tools > Changes by: Jonas Karlsson <mohjive> 07/03/08 12:25:08 > > Modified files: > ChrootCompile/bin: BatchChrootCompile > > Log message: > Added support for signing of packages to BatchChrootCompile > > CVSWeb URLs: > http://cvs.savannah.gnu.org/viewcvs/tools/ChrootCompile/bin/BatchChrootCompile?cvsroot=goboscripts&r1=1.13&r2=1.14 > > Patches: > Index: BatchChrootCompile > =================================================================== > RCS file: /sources/goboscripts/tools/ChrootCompile/bin/BatchChrootCompile,v > retrieving revision 1.13 > retrieving revision 1.14 > diff -u -b -r1.13 -r1.14 > --- BatchChrootCompile 8 Mar 2007 08:56:06 -0000 1.13 > +++ BatchChrootCompile 8 Mar 2007 12:25:08 -0000 1.14 > @@ -13,6 +13,7 @@ > scriptUsage="[packages_list_file]" > scriptNotes="Default package list file is "`readlink -f > "$scriptPath/../Data/PackagesList"` > Add_Option_Entry "s" "start-at" "Start at a given package from the list." > "" > +Add_Option_Boolean "S" "no-sign" "Do not try to sign the resulting packages." > > Parse_Options "$@" > > @@ -31,10 +32,11 @@ > > # Save stdin in fd 6 > exec 6<&0 > +succeeded_apps=""
Please don't use underline for variable names. There's a convention on names basically represented by the following rules: succeededapps -> variable succeeded_apps() -> local function Succeeded_Apps() -> global/exported function Could you please rename it? -- Lucas powered by /dev/dsp _______________________________________________ gobolinux-devel mailing list gobolinux-devel@lists.gobolinux.org http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel