>!
I found several problems with the GenFstab in the 014RC ISO.
1) bootableflag and id require more of the "fdisk -l" output than is saved in
the varable partition. I created a new variable pt to take care of this
2) the test 'test ! -z "${extralist}" && if echo "${extralist}" |
grep -q "${drive}${partitionnumber}"' never reaches the else that unsets
several variables if there is no extralist
3) "partitionnumber" is misspelled in one place ("partionnumber")
4) an incorrect line is added to the output if the id is 5
5) the arrays "types" and "drives" are not correctly expanded by $types and
$drives; something like [EMAIL PROTECTED] is needed
Here are the diffs from my fixes:
diff old/GenFstab newFstab
92,93c92,94
< bootableflag=$(echo "${partition}" | awk {'print $2'})
< test ! -z "${extralist}" && if echo "${extralist}" |
grep -q "${drive}${partitionnumber}"
---
> pt=$(fdisk -l | grep "${drive}${partitionnumber}")
> bootableflag=$(echo "${pt}" | awk {'print $2'})
> if [ ! -z "${extralist}" -a "$(echo ${extralist} | grep -q
${drive}${partitionnumber})" ]
106,107c107,108
< then id=$(echo "${partition}" | awk {'print $6'})
< else id=$(echo "${partition}" | awk {'print $5'})
---
> then id=$(echo "${pt}" | awk {'print $6'})
> else id=$(echo "${pt}" | awk {'print $5'})
171c172
< [ -z "${mountpoint}" ] && mountpoint="/Mount/$(Uppercase
${drive})${partionnumber}"
---
> [ -z "${mountpoint}" ] && mountpoint="/Mount/$(Uppercase
${drive})${partitionnumber}"
178,180c179,182
< echo "${comment}" | grep -q "^#" || comment="# ${comment}"
< echo "${comment}"
< echo "${partition} ${mountpoint} ${filesystem} ${mountoptions}
${checks}"
---
> if [ ! "$id" = "5" ]; then
> echo "${comment}" | grep -q "^#" || comment="# ${comment}"
> echo "${comment}"
> echo "${partition} ${mountpoint} ${filesystem} ${mountoptions}
${checks}"
181a184
> fi
191,192c194,195
< for t in $types; do
< for d in $drives; do
---
> for t in [EMAIL PROTECTED]; do
> for d in [EMAIL PROTECTED]; do
_______________________________________________
gobolinux-devel mailing list
gobolinux-devel@lists.gobolinux.org
http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel
