On 8/26/07, Jonas Karlsson <[EMAIL PROTECTED]> wrote:
> While talking about dependencies and such, I'd like to readd this patch to
> RecipeLint.
Ok, but here are some suggestions/comments:
> --- RecipeLint 18 Nov 2006 15:15:00 -0000 1.30
> +++ RecipeLint 20 Nov 2006 20:21:55 -0000 1.31
> @@ -683,15 +683,6 @@
> grep -q "^# \*Warning\*" $depfile && {
> ERROR "Dependencies file contains unmatched library
> dependencies."
> }
> + while read line
> + do
> + bad_dep=`echo $line | sed -r -e '/.*\ [><=]?\ .*/d' -e '/^#.*/d'
> -e '/^\s*$/d'`
> + if [ ! -z "$bad_dep" ]
> + then
> + WARN "Old style dependency/Bad line in Dependensies: $bad_dep"
Old-style should be a WARN, bad-line should be an ERROR. (And there's
a typo in Dependencies".) In the old-style note, maybe add an
informative message such as "Old style dependency 'Foo 1.0' in
Resources/Dependencies. You may want to change this to something like
'Foo >= 1.0' " (Yeah, it's a bit extra work, but I'm hoping it will
encourage users to fix them.)
-- Hisham
_______________________________________________
gobolinux-devel mailing list
gobolinux-devel@lists.gobolinux.org
http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel
