On 10/14/07, Jonas Karlsson <[EMAIL PROTECTED]> wrote: > On Sun, 14 Oct 2007 10:50:51 +0200, Lucas C. Villa Real <[EMAIL PROTECTED]> > wrote: > > > On 10/14/07, Jonas Karlsson <[EMAIL PROTECTED]> wrote: > >> CVSROOT: /sources/goboscripts > >> Module name: tools > >> Changes by: Jonas Karlsson <mohjive> 07/10/14 08:27:35 > >> > >> Modified files: > >> ConfigTools/bin: GenFstab > >> > >> Log message: > >> Added check to GenFstab to see if a device is a usb device and, if > >> so, do not generate fstab entry for it. Fixes bug #175. > > > > I think we should only skip a usb device if it doesn't contain the > > root partition, as it's very common to see users wishing to install > > Gobo in their usb keys. > > > Ok, commited a fix. But thinking of it, wouldn't it be better if the > installer passed an option, like '--root=/System/Kernel/Devices/sda3' > to GenFstab instead? After all the installer knows which the root > partition is.
We just have to make sure that a 'fdisk -l' compatible output is sent, otherwise the comparisons will fail. With the proper testings this can be a good improvement to avoid to rely in our current 'root' heuristics. -- Lucas powered by /dev/dsp _______________________________________________ gobolinux-devel mailing list gobolinux-devel@lists.gobolinux.org http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel
