On Feb 8, 2008 6:57 PM, Michael Homer <[EMAIL PROTECTED]> wrote:
> CVSROOT: /sources/goboscripts
> Module name: tools
> Changes by: Michael Homer <mwh> 08/02/09 02:57:01
>
> Modified files:
> Scripts : Makefile
> Added files:
> Scripts/bin : UseFlags
>
> Log message:
> Initial useflags backing code
Hi! First of all, thanks a lot for this commit! I'm amazed by how
small its implementation actually is -- congrats. I've just 2
questions:
> + if os.path.exists(goboSettings + '/UseFlags.conf'):
> + f = open(goboSettings + '/UseFlags.conf')
> + mergeFlags(flags, f)
> + f.close()
Could you please commit a skeleton for UseFlags.conf? Something in the
same way as the UserDefinedModules array in $goboSettings/BootOptions
would be enough.
> + if 'USE' in os.environ:
> + mergeFlags(flags, os.environ['USE'].split(' '))
Should we ship an empty/commented Resources/Environment file with
Compile just to illustrate how one is expected to define it? I think
it makes sense.
Cheers,
--
Lucas
powered by /dev/dsp
_______________________________________________
gobolinux-devel mailing list
[email protected]
http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel
