On Tue, Mar 25, 2008 at 5:41 PM, Nick Matteo <[EMAIL PROTECTED]> wrote:
> Hi,
> I've noticed that when using "PrepareProgram" the output of configure
> wasn't getting colored as it usually does. I'm rather attached to the
> coloring (it makes it much easier to find possible dependencies!)
>
> I tracked it down to line 279:
> "$configureprogram" "[EMAIL PROTECTED]" "[EMAIL PROTECTED]" >&$normalFD
> 2>&1 | Color_Output configure
>
> After removing the part ">&$normalFD", it worked fine:
> "$configureprogram" "[EMAIL PROTECTED]" "[EMAIL PROTECTED]" 2>&1 |
> Color_Output configure
>
> It seems to have the same effect whether PrepareProgram is called
> directly, or from Compile.
I couldn't reproduce the problem here -- just tried Compile and
configure appeared colored. In any case, I moved ">&$normalFD" to the
end of the command.
> Since we're on the subject of "niggling problems in Scripts," here are
> some more.
>
> bin/NoRecipe, line 5, calls the nonexistent function "ParseConf"; it should
> be:
> Parse_Conf Compile.conf
Fixed, thanks.
> bin/SandboxInstall, by default, gives uncolored make output (Compile
> passes --make ColorMake to it to get color.)
> Changing line 22 makes coloring the default when called directly, also:
> Add_Option_Entry "m" "make" "Use the given variant of make (ie:
> cmake). Use in recipe_type={makefile,configure}" "ColorMake"
Nice catch -- applied.
> I'm not sure if this is intentional (or important), but in
> Functions/File, Is_Empty_Directory() thinks that directories with
> hidden files are empty.
> If directories with dotfiles aren't empty, then lines 53 and 59 should both
> be
> anyfiles=$(ls -A "$1" 2> /dev/null)
> (adding the -A option.)
Fixed as well.
Thanks for the reports!
-- Hisham
_______________________________________________
gobolinux-devel mailing list
gobolinux-devel@lists.gobolinux.org
http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel
