On Fri, May 9, 2008 at 3:43 PM, Carlo Calica <[EMAIL PROTECTED]> wrote: > On Thu, May 8, 2008 at 4:26 PM, Lucas C. Villa Real > <[EMAIL PROTECTED]> wrote: >> >> An obvious fix is to simply ignore the errors if the offending file is >> a symlink, as proposed in this patch. Is it ok to commit this, or do >> you want to think in a more elaborated solution? (I'm ok with this >> one) >> > > The elaborate solution would be to store the symlink dest in FileHash. > Then the signature could verify that. But I don't see that being a > very large gain. Do these symlinks stay within the package or do they > cross package boundaries?
I had already implemented this, but the changes in ListProgramFiles meant that links never got to Gen_FileHash properly. I bumped up the FileHash format to version 2.1 and now symlink destinations are properly stored. As a workaround, symlinks are ignored for FileHash versions <= 2.1. Indeed, adding versioning to the format was a really good decision. Which brings to mind that perhaps we should have used compile_version to avoid breaking so many recipes when intrusive features were added. OTOH, littering the code with Compile version checks could get ugly fast. -- Hisham _______________________________________________ gobolinux-devel mailing list gobolinux-devel@lists.gobolinux.org http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel
