On Sun, Sep 28, 2008 at 1:02 PM, Lucas C. Villa Real
<[EMAIL PROTECTED]> wrote:
> On Sun, Sep 28, 2008 at 5:54 AM, Jonas Karlsson <[EMAIL PROTECTED]> wrote:
>>> if [ "$packagename" = "Scripts" ]
>>> then
>>> - cd "${goboPrograms}/$packagename/$packageversion/src"
>>> + cd "${goboPrograms}/$packagename/$packageversion"
>>> make --silent
>>> cd "${goboPrograms}/$packagename/$packageversion/bin"
>>> PATH=$PWD:$PATH ./SymlinkProgram Scripts "$packageversion"
>>>
>> Regarding this code snippet, do we really need this special casing for
>> Scripts?
>
> The packager is already in charge of calling 'make' before releasing a
> new Scripts package, so running make+SymlinkProgram doesn't make sense
> anymore. IIRC Detsch is the one who originally wrote that, so it would
> be good to hear his opinion, too.
The make --silent command can certainly be removed.
In very old versions of scripts, the rest of the code block was
needed, as installation of the scripts package would break when run
with the SymlinkProgram version of the package being unlinked. That
does not seem to be the case anymore (verified with a quick test
here).
The only reason to keep the block would be to ensure that the Scripts
package is linked correctly if some fix is added to the SymlinkProgram
script. I.e., when there is some difference between running the old
(linked) or the new (going to be linked) version of SymlinkProgram.
IMO, that is not relevant anymore, and the whole block can be removed
(just give it some test before committing).
--
Andre Detsch
_______________________________________________
gobolinux-devel mailing list
gobolinux-devel@lists.gobolinux.org
http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel
