On Fri, Apr 23, 2010 at 3:07 AM, Baffo 32 <baff...@gmail.com> wrote:
> The recipe store currently contains two conflicting copies of Bash:
> 4.1.002 (from me) and 4.1.2 (from Jonas Karlsson). 4.1.2 works fine,
> but 4.1.002 will not compile due to extraneous patches.
>
> Unfortunately, GetRecipe (and hence Compile) will arbitrarily select
> the broken recipe, if and only if no local recipe is found. It is
> selected because the two are numerically equal and "GetAvailable
> --type=recipe" lists 4.1.002 earlier in its output.
I've removed the broken recipe from the store, which should propagate
soon. Thanks for the tip.
>
> The attached patch adds a check to RecipeLint to ensure a conflict
> like this does not happen again, by rejecting version numbers with
> prefixed zeros. There are currently 208 recipes in the store failing
> this check.
I'd prefer not to do this since there can be legitimate (social) uses
for that sort of numbering (Bash and Vim come to mind, though often we
just roll the patches into the headline release). It's only a problem
when we have both for the same program. For these
numbered-patches-instead-of-actual-releases programs I would lean
towards using the leading zeroes from upstream, but I don't feel
strongly about it. Jonas has used the bare number in his Bash recipe
so he may prefer that. I will defer to what anybody else thinks on the
subject.
-Michael
_______________________________________________
gobolinux-devel mailing list
gobolinux-devel@lists.gobolinux.org
http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel
