There isn't a call to client.close in the jabber code, and thus it
makes God leak memory when you use it.

If you make the call to close it gets a lot better (done in
http://github.com/woahdae/god/commit/210907fa9a9fdf765b7241666ac93682adc372db),
but still uses more memory than it should and seems to leak, at least
for a small number of messages.

The better way to do it would be to manage a single connection for all
messages, which seems to stop the leaking and use the least amount of
total memory (as well as execute much, much faster). This was done in
http://github.com/woahdae/god/commit/66ec9e6f3da373df9acdf6592fb333157391a592

I'll send a pull request to the author, but I thought I'd post it here
just for kicks. Sometimes pull requests seem to go unnoticed.

Also, if you want to see the tests I wrote and the results (against
the latter patch), http://gist.github.com/gists/39213

-Woody
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"god.rb" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/god-rb?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to