Hi,
I don't know if this is the right place, but I'm struggling for a few hours 
now to get my go-swagger document working again and maybe you guys can help 
me :)

I upgraded from go 1.18 to go 1.19 --> comments for go-swagger are 
reformatted and go-swagger breaks. So far, so bad. I have read a lot of 
issues and comments. Now I'm at the point with the latest go 1.19.2 and 
go-swagger v0.30.3 version. Now the comments are still being reformatted, 
but I thought with go-swagger v0.30.0 or higher go-swagger can deal with 
the new comment format and create correct swagger docs?

What am I missing?

Thanks in advance
Raphael


Ivan Porto Carrero schrieb am Donnerstag, 18. August 2022 um 17:51:48 UTC+2:

> I think that indenting everything should work, we are detecting the yaml 
> marker, collect all the lines in the comment until we see a thing that 
> starts with swagger: or the comment block ends and then proceed to 
> uncomment and remove the indentation based on the first line after the --- 
> marker.
>
> The branch I'm working in was reformatted by go 1.19 fmt and still passes 
> the tests but I don't think that our test cases capture all the real-world 
> use cases.
>
> On Wednesday, August 17, 2022 at 8:33:08 PM UTC-7 crod...@gmail.com wrote:
>
>> I think the parsing rules for go-swagger are described here:
>>
>> https://goswagger.io/use/spec.html#parsing-rules
>>
>> It looks like this issue has affected other codebases such as Cockroachdb:
>>
>>
>> https://github.com/cockroachdb/cockroach/pull/86049#issuecomment-1213573808
>>
>> —
>> Craig
>>
>>
>> On Wednesday, August 17, 2022 at 7:20:11 PM UTC-7 Ian Lance Taylor wrote:
>>
>>> What are the constraints on go-swagger? Can one simply indent 
>>> everything to get a code block? 
>>>
>>> Ian 
>>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"golang-nuts" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to golang-nuts+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/golang-nuts/20d29604-3414-4b3d-a379-08d50ddd472fn%40googlegroups.com.

Reply via email to