https://bugzilla.redhat.com/show_bug.cgi?id=1191944
Bug ID: 1191944
Summary: downloaded testsuite
Product: Fedora
Version: rawhide
Component: golang
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
CC: [email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected], [email protected]
Description of problem:
golang testsuite depends on hg (mercurial) and then it would get downloaded
from network during build violating:
https://fedoraproject.org/wiki/Packaging:Guidelines#Build_time_network_access
Version-Release number of selected component (if applicable):
golang-1.4.1-1.fc23
How reproducible:
Always.
Steps to Reproduce:
http_proxy=http://localhost:3128/ https_proxy=http://localhost:3128/
rpmbuildlocal -bb *.spec
Actual results:
# Checking API compatibility.
Error running hg clone on go.tools: exit status 1
** unknown exception encountered, please report by visiting
[...]
failed build.
- the error is due to unrelated mercurial Bug 1185641 - but the primary
problem is that the build should not depend on any remote network data.
Expected results:
Successful build.
Additional info:
When you check the Koji build
https://kojipkgs.fedoraproject.org//work/tasks/2317/8642317/build.log
one can see:
# Checking API compatibility.
Skipping cmd/api checks; hg not available
While during plain local build it finds hg and it tries to use it.
Bug#1: Koji build process differs from local build process.
(a) Either disable "Checking API compatibility" to match the Koji build
(b) or BuildRequires: mercurial so that even Koji runs the testsuite.
(1a) is bad, testsuite should be run during build to sanity check the package.
(1b) is bad as it would violate:
https://fedoraproject.org/wiki/Packaging:Guidelines#Build_time_network_access
Therefore IMO the Fedora packaging should bundle a downloaded snapshot of the
testsuite.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
golang mailing list
[email protected]
https://lists.fedoraproject.org/mailman/listinfo/golang
