Hi, I have submitted the first of my dependency review requests here:
https://bugzilla.redhat.com/show_bug.cgi?id=1712280 Feedback is greatly appreciated so I can clean anything up on the next set of dependencies. I am working on the main application packaging for gocryptfs (https://github.com/rfjakob/gocryptfs/) and have hit a few questions: 1. The upstream provides specific source tarballs for each version here, https://github.com/rfjakob/gocryptfs/releases - I am planning to use these as opposed to the gomacros to determine a git tag to pull. Is there a reason not to do this? 2. The upstream build script sets up some values to be included in the executables version string. I presume this helps with debugging. I am told that the Go SIG would prefer to see the macros used for building rather than the upstream build script. This is fine, except I am not sure how to handle these values. Specifically, they are: GITVERSION=$(cat VERSION) GITVERSIONFUSE=$(rpm -q golang-github-hanwen-fuse-devel --queryformat '%{version}') BUILDDATE=$(date +%Y-%m-%d) These can be set, presumably, somehow in the spec file (i haven't tested my ideas here yet). They are passed to `go build` as part of the ldflags, specifically as: "-X main.GitVersion=$GITVERSION -X main.GitVersionFuse=$GITVERSIONFUSE -X main.BuildDate=$BUILDDATE" prepended to any existing ldflags How do you pass this information with the macros? thanks, bex -- Brian "bex" Exelbierd (he/him/his) Fedora Community Action & Impact Coordinator @bexelbie | http://www.winglemeyer.org bexel...@redhat.com | b...@pobox.com _______________________________________________ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
