[google-caja] metaweta commented on revision r2934.
Details are at http://code.google.com/p/google-caja/source/detail?r=2934
Score: Neutral
Line-by-line comments:
File: /changes/erights/nextfruit/trunk/src/com/google/caja/cajita.js (r2934)
===============================================================================
Line 223: return asSimpleFunc(this).apply(USELESS, arguments);
-------------------------------------------------------------------------------
If you're removing "simple" do it everywhere unless it has
meaning.
Line 2660: var MAGIC_TOKEN = Token('MAGIC_TOKEN');
-------------------------------------------------------------------------------
Might be useful for debugging to include the index number in the token name.
Line 2724: return key[myMagicIndexName];
-------------------------------------------------------------------------------
I think you meant to delete this line; otherwise everything after this is
dead code. Add a test that would have caught this.
File:
/changes/erights/nextfruit/trunk/src/com/google/caja/demos/calendar/demo-cajoled.html
(r2934)
===============================================================================
Line 122: imports.$v = valijaMaker(imports);
-------------------------------------------------------------------------------
valijaMaker.CALL___(imports)
File:
/changes/erights/nextfruit/trunk/src/com/google/caja/parser/quasiliteral/CajitaRewriter.java
(r2934)
===============================================================================
Line 883: "@o is imported, we check that this
static permission was actually " +
-------------------------------------------------------------------------------
indentation
File:
/changes/erights/nextfruit/trunk/tests/com/google/caja/demos/benchmarks/BenchmarkRunner.java
(r2934)
===============================================================================
Line 105: + "testImports.$v =
valijaMaker.CALL___(testImports);\n"
-------------------------------------------------------------------------------
Make this change everywhere valijaMaker is invoked (demo-cajoled.html,
index.html, etc.)
Respond to these comments at
http://code.google.com/p/google-caja/source/detail?r=2934
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to
http://groups.google.com/group/google-caja-discuss
To unsubscribe, email [EMAIL PROTECTED]
-~----------~----~----~----~------~----~------~--~---
