http://codereview.appspot.com/12479/diff/1/2
File tools/dashboard/dashboard.pl (right):
http://codereview.appspot.com/12479/diff/1/2#newcode109
Line 109: our $SELENIUM = "/opt/svn/selenium.sh";
requireExe $ANT;
Should this file be part of this CL?
Maybe make the requireExe line up with the others.
http://codereview.appspot.com/12479/diff/1/2#newcode119
Line 119: our $BROWSER_FORMAT =
qr/\bVarZ:([\w\.\-]+)=(\d+(?:\.\d+)?)\b/;
Is this used?
http://codereview.appspot.com/12479/diff/1/2#newcode169
Line 169:
extractSeleniumSummary("$REPORTS_DIR/selenium/TESTS-TestSuites.xml",
\...@status_log);
wrap to 80 columns here and elsewhere
http://codereview.appspot.com/12479/diff/1/2#newcode374
Line 374: sub extractSeleniumSummary($$) {
Can you put in a comment with an example of what you're parsing.
http://codereview.appspot.com/12479
