[Caja] fix 1056, NPE when cajoling , and relax about mandatory attrs</span></a></span> </h1> <p class="darkgray font13"> <span class="sender pipe"><a href="/search?l=google-caja-discuss@googlegroups.com&q=from:%22felix8a%22" rel="nofollow"><span itemprop="author" itemscope itemtype="http://schema.org/Person"><span itemprop="name">felix8a</span></span></a></span> <span class="date"><a href="/search?l=google-caja-discuss@googlegroups.com&q=date:20090701" rel="nofollow">Wed, 01 Jul 2009 10:24:30 -0700</a></span> </p> </div> <div itemprop="articleBody" class="msgBody"> <!--X-Body-of-Message--> <pre style="margin: 0em;"> Reviewers: ihab.awad,</pre><pre> Description: The new html emitter is more aggressive about emitting default values for attributes that the html spec claims are not optional. 1. The spec for <textarea> says the cols= attribute isn't optional, but doesn't specify an acceptable default value. caja tries to emit a default anyway, which is an NPE. 2. It seems to me that caja should not be forcing default values if I haven't specified one. For example, <img> without alt= is meaningfully different from <img alt=''>. I don't see any reason for caja to normalize these attributes, rather than letting the browser do it naturally. Please review this at <a rel="nofollow" href="http://codereview.appspot.com/90071">http://codereview.appspot.com/90071</a> Affected files: M src/com/google/caja/lang/html/html4-attributes-defs.json M src/com/google/caja/plugin/templates/TemplateCompiler.java M tests/com/google/caja/plugin/templates/TemplateCompilerTest.java </pre> </div> <div class="msgButtons margintopdouble"> <ul class="overflow"> <li class="msgButtonItems"><a class="button buttonleft " accesskey="p" href="msg04001.html">Previous message</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="c" href="index.html#04002">View by thread</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="i" href="maillist.html#04002">View by date</a></li> <li class="msgButtonItems textalignright"><a class="button buttonright " accesskey="n" href="msg04003.html">Next message</a></li> </ul> </div> <a name="tslice"></a> <div class="tSliceList margintopdouble"> <ul class="icons monospace"> </ul> </div> <div class="overflow msgActions margintopdouble"> <div class="msgReply" > <h2> Reply via email to </h2> <form method="POST" action="/mailto.php"> <input type="hidden" name="subject" value="[Caja] fix 1056, NPE when cajoling <textarea>, and relax about mandatory attrs"> <input type="hidden" name="msgid" value="00163630e87f04ae4c046da832a2@google.com"> <input type="hidden" name="relpath" value="google-caja-discuss@googlegroups.com/msg04002.html"> <input type="submit" value=" felix8a "> </form> </div> </div> </div> <div class="aside" role="complementary"> <div class="logo"> <a href="/"><img src="/logo.png" width=247 height=88 alt="The Mail Archive"></a> </div> <form class="overflow" action="/search" method="get"> <input type="hidden" name="l" value="google-caja-discuss@googlegroups.com"> <label class="hidden" for="q">Search the site</label> <input class="submittext" type="text" id="q" name="q" placeholder="Search google-caja-discuss"> <input class="submitbutton" name="submit" type="image" src="/submit.png" alt="Submit"> </form> <div class="nav margintop" id="nav" role="navigation"> <ul class="icons font16"> <li class="icons-home"><a href="/">The Mail Archive home</a></li> <li class="icons-list"><a href="/google-caja-discuss@googlegroups.com/">google-caja-discuss - all messages</a></li> <li class="icons-about"><a href="/google-caja-discuss@googlegroups.com/info.html">google-caja-discuss - about the list</a></li> <li class="icons-expand"><a href="/search?l=google-caja-discuss@googlegroups.com&q=subject:%22%5C%5BCaja%5C%5D+fix+1056%2C+NPE+when+cajoling+%3Ctextarea%3E%2C+and+relax+about+mandatory++attrs%22&o=newest&f=1" title="e" id="e">Expand</a></li> <li class="icons-prev"><a href="msg04001.html" title="p">Previous message</a></li> <li class="icons-next"><a href="msg04003.html" title="n">Next message</a></li> </ul> </div> <div class="listlogo margintopdouble"> </div> <div class="margintopdouble"> </div> </div> </div> <div class="footer" role="contentinfo"> <ul> <li><a href="/">The Mail Archive home</a></li> <li><a href="/faq.html#newlist">Add your mailing list</a></li> <li><a href="/faq.html">FAQ</a></li> <li><a href="/faq.html#support">Support</a></li> <li><a href="/faq.html#privacy">Privacy</a></li> <li class="darkgray">00163630e87f04ae4c046da832a2@google.com</li> </ul> </div> </body> </html>