http://codereview.appspot.com/88157/diff/1/3
File src/com/google/caja/plugin/domita.js (right):

http://codereview.appspot.com/88157/diff/1/3#newcode1576
Line 1576: TamePseudoNode.prototype.replaceChild = function () {
On 2009/07/13 21:04:11, ihab.awad wrote:
The original had the wrong signature (1 instead of 2 args); I would
think it
would be better to fix the signature, as a form of documentation for
code
readers, rather than delete it, even if the arguments are never used.

but that function is not just replaceChild, it's also removeChild, etc.
there isn't a consistent signature for all those functions, so I think
it's better to have an empty signature rather than a misleading
signature.

http://codereview.appspot.com/88157

Reply via email to