[Caja] Re: Initial check in for securable modules

[maoziqing]

Committed revision 3570.


http://codereview.appspot.com/91107/diff/1028/18
File src/com/google/caja/parser/quasiliteral/CajitaRewriter.java
(right):

http://codereview.appspot.com/91107/diff/1028/18#newcode501
Line 501: substitutes="___.markFuncFreeze(function() {\n"
On 2009/07/14 20:33:45, ihab.awad wrote:

Usually, we don't bother to terminate quasi expressions with "\n" ...

it's

probably good to remain consistent.

Done.

http://codereview.appspot.com/91107/diff/1028/18#newcode504
Line 504: + "      @body\n"
On 2009/07/14 20:33:45, ihab.awad wrote:

Missing semicolon.

Done.

http://codereview.appspot.com/91107/diff/1028/18#newcode514
Line 514: + "  })();")
On 2009/07/14 20:33:45, ihab.awad wrote:

Indent this line one step out.

Done.

http://codereview.appspot.com/91107/diff/1028/18#newcode537
Line 537: // error messages were logged in the function
fetctStaticModule
On 2009/07/14 20:33:45, ihab.awad wrote:

Trailing whitespace on this line. Also, fetchStaticModule mis-spelled.

Done.

http://codereview.appspot.com/91107/diff/1028/16
File tests/com/google/caja/parser/quasiliteral/CajitaRewriterTest.java
(right):

http://codereview.appspot.com/91107/diff/1028/16#newcode2304
Line 2304: MessageLevel.FATAL_ERROR);
On 2009/07/14 20:33:45, ihab.awad wrote:

Maybe add a test for the "cannot load dynamic" failure condition?

Done.

http://codereview.appspot.com/91107