On 2009/07/16 18:38:50, ihab.awad wrote:
LGTM++
See comments.
http://codereview.appspot.com/91117/diff/1/5 File tests/com/google/caja/plugin/DomitaTest.java (right):
http://codereview.appspot.com/91117/diff/1/5#newcode128 Line 128: assertTrue("Too many wait rounds.", waitRounds <
waitRoundLimit);
I would suggest formatting the "clicking" and "waiting" loops so they
have
identical line spacing, etc., to highlight their similarity.
ok
http://codereview.appspot.com/91117/diff/1/4 File tests/com/google/caja/plugin/domita_test_untrusted.html (right):
http://codereview.appspot.com/91117/diff/1/4#newcode2387 Line 2387: false); Please indent above lines 2 more spaces. Same elsewhere.
ok
http://codereview.appspot.com/91117/diff/1/3 File tests/com/google/caja/plugin/jsunit.js (right):
http://codereview.appspot.com/91117/diff/1/3#newcode131 Line 131: console.log('FAIL: ' + testName); Why not also updateStatus() on failure, since you updateStatus() on
passing? ah, right. forgot to do that. http://codereview.appspot.com/91117
