LGTM
http://codereview.appspot.com/96075/diff/8/2010 File tests/com/google/caja/parser/quasiliteral/CommonJsRewriterTestCase.java (right): http://codereview.appspot.com/96075/diff/8/2010#newcode53 Line 53: */ Oh oh oh oh oh ... the whole of testIn() was not being run in the case of Valija since it was getting clobbered by the subclass. Do'owwww! :( Mike Stay is going to look into this since he was the last one to mess with that stuff. http://codereview.appspot.com/96075/diff/8/2009 File tests/com/google/caja/parser/quasiliteral/DefaultValijaRewriterTest.java (right): http://codereview.appspot.com/96075/diff/8/2009#newcode541 Line 541: "___.grantFunc(testImports, 'fail');" + Ah ... so we were running with this undefined and our "fail()-ures" were because of the undefined symbol, not proper calls to fail()? Wow. http://codereview.appspot.com/96075
