http://codereview.appspot.com/96079/diff/1/2
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java
(right):

http://codereview.appspot.com/96079/diff/1/2#newcode93
Line 93: String origContent = content.getContent();
So this code is still serializing the DOM, caja is parsing it, then
re-serializing it, then we're parsing again. This is the primary reason
why caja still can't be used in production on a lot of properties. I was
under the impression that we were going to fix this so that caja
understood a DOM as input.

http://codereview.appspot.com/96079/diff/1/2#newcode102
Line 102: Document doc = content.getDocument();
These two lines will result yet another parse. content.setContent("")
should be removed. If a problem occurs when cajoling, handle it (put it
in a finally block if you want to be really sure).

http://codereview.appspot.com/96079

Reply via email to