[Caja] Re: Tests broken on head

[felix]

there's a pending CL from mike stay that fixes that

On 7/22/09 15:08, Mike Samuel wrote:

The test trace is

testIn  Failure junit.framework.AssertionFailedError: should throw
TypeError at /com/google/caja/cajita.js:2572 (handle) at
/com/google/caja/cajita.js:1735 (callPub) at
/com/google/caja/cajita.js:2654 (loadModule) at testIn-cajoled:2

junit.framework.AssertionFailedError:
junit.framework.AssertionFailedError: should throw TypeError
        at /com/google/caja/cajita.js:2572 (handle)
        at /com/google/caja/cajita.js:1735 (callPub)
        at /com/google/caja/cajita.js:2654 (loadModule)
        at testIn-cajoled:2


        at com.google.caja.util.RhinoTestBed.runJs(RhinoTestBed.java:104)
        at 
com.google.caja.parser.quasiliteral.DefaultValijaRewriterTest.rewriteAndExecute(DefaultValijaRewriterTest.java:510)
        at 
com.google.caja.parser.quasiliteral.RewriterTestCase.rewriteAndExecute(RewriterTestCase.java:67)
        at 
com.google.caja.parser.quasiliteral.RewriterTestCase.assertConsistent(RewriterTestCase.java:226)
        at 
com.google.caja.parser.quasiliteral.RewriterTestCase.assertConsistent(RewriterTestCase.java:220)
        at 
com.google.caja.parser.quasiliteral.CommonJsRewriterTestCase.testIn(CommonJsRewriterTestCase.java:45)

and the offending test is

     assertConsistent(
         "var flag = true;" +
         "try { 'length' in '123' }" +
         "catch (e) { flag = false; }" +
         "if (flag) { fail ('should throw TypeError'); }" +
         "true;");



2009/7/22 Mike Samuel<mikesam...@gmail.com>:

It looks like a recent change broke some of the Domita tests.  The
tests might have been broken before but never run due to some
unintentional overriding of testLn.
Is anyone working on fixing these?