On 2009/07/28 01:18:22, MikeSamuel wrote:
http://codereview.appspot.com/98051/diff/1/2 File src/com/google/caja/plugin/domita.js (right):
http://codereview.appspot.com/98051/diff/1/2#newcode2586 Line 2586: return defaultTameNode(this.node___.insertCell(0 + index), this.editable___); What do you want (0 + index) to do? It definitely does not guarantee that the result is an integer or that
it is in
a sensible range.
I just wanted it not to be an object; I don't think it matters, though. What would you prefer to have in that position? Just "index", or something that guarantees it's an integer?
http://codereview.appspot.com/98051/diff/1/2#newcode2627 Line 2627: if (!this.editable___) { throw new Error(NOT_EDITABLE); } Why are create methods contingent on editability?
Don't know. I just copied the existing ones. http://codereview.appspot.com/98051
