http://codereview.appspot.com/98051/diff/1/2
File src/com/google/caja/plugin/domita.js (right):

http://codereview.appspot.com/98051/diff/1/2#newcode2586
Line 2586: return defaultTameNode(this.node___.insertCell(0 + index),
this.editable___);
Not being an object is an improvement, but there's no reason to map the
string 'foo__' to '0foo__'.

You should require that the input be valid because otherwise you're
allowing access to badly defined behavior.

You should require that the index be valid according to the spec:
http://www.w3.org/TR/DOM-Level-2-HTML/html.html#ID-68927016

insertCell modified in DOM Level 2
    Insert an empty TD cell into this row. If index is -1
    or equal to the number of cells, the new cell is
    appended.
    Parameters

    index of type long
        The place to insert the cell, starting from 0.

It looks like valid values are integers in [-1, children.length].

http://codereview.appspot.com/98051

Reply via email to