LGTM


http://codereview.appspot.com/109083/diff/1006/1009
File src/com/google/caja/plugin/CssRuleRewriter.java (right):

http://codereview.appspot.com/109083/diff/1006/1009#newcode119
Line 119: elName.getFilePosition(), ".vdoc-body___"),
Should ".vdoc-body___" be entered into some collection of static final
whatsits somewhere?

http://codereview.appspot.com/109083/diff/1006/1008
File tests/com/google/caja/plugin/CssRuleRewriterTest.java (left):

http://codereview.appspot.com/109083/diff/1006/1008#oldcode57
Line 57: "[ '.', ' body.ie6 {\\n  color: blue\\n}' ]");
So -- just so I understand: Previously, we were passing through the
"body" tag but effectively neutering it by prefixing with the gadget ID
class?

http://codereview.appspot.com/109083/diff/1006/1008
File tests/com/google/caja/plugin/CssRuleRewriterTest.java (right):

http://codereview.appspot.com/109083/diff/1006/1008#newcode60
Line 60: "[ '.vdoc-body___.', ' {\\n  font-size: 12pt\\n}' ]");
And fwiw, the new stuff looks reasonable, so no need to hold up the
checkin.

http://codereview.appspot.com/109083

Reply via email to