Reviewers: metaweta,

Description:
http://code.google.com/p/google-caja/issues/detail?q=1105

This partly addresses issue 1105
  Disallowed property values:
    font: x-small;
    font: 100%;
    font: arial;
by coercing these to, respectively,
    font-size: x-small;
    font-size: 100%;
    font-family: arial;

It takes care not to coerce things like
    font: inherit  // Illegal, but has a clear meaning
    font: caption  // Legal

It does coerce some typos, and gives an error message at the
right place, but possibly misleading since
    font: waption
is coerced to
    font-family: "waption"
instead of being reported with a bad property value message.

font:waption is probably treated as an unknown font-name by most
browsers, and previously we would not report a bad value message
for the equally widgy
  font: 12px waption

See the added testcases for details.

Please review this at http://codereview.appspot.com/115053

Affected files:
  M     src/com/google/caja/plugin/CssValidator.java
  M     src/com/google/caja/plugin/PluginMessageType.java
  M     tests/com/google/caja/plugin/CssValidatorTest.java


Reply via email to