updated snapshot
http://codereview.appspot.com/110079/diff/1/7 File tests/com/google/caja/opensocial/example-rewritten.xml (right): http://codereview.appspot.com/110079/diff/1/7#newcode31 Line 31: ; On 2009/09/03 01:52:48, MikeSamuel wrote:
Why is this semi on the next line?
hm. the previous line is 77 chars, so it seems like 77+1 shouldn't cause a split. it looks like what's happening is, the previous line is actually 79 chars. for some reason, example-rewritten.xml has lost 2 chars of indent, versus what's actually produced by the cajoler. this difference doesn't cause a test failure, because the test ignores all indentation when comparing the result. I've refreshed example-rewritten.xml from the actual result, and also added a testcase for long lines in JsPrettyPrinterTest. http://codereview.appspot.com/110079/diff/1/9 File tests/com/google/caja/service/CajolingServiceTest.java (right): http://codereview.appspot.com/110079/diff/1/9#newcode219 Line 219: String indent = " "; On 2009/09/03 01:52:48, MikeSamuel wrote:
I think this is defunct now, since the spaces take less space than the
+ indent
+ " below.
ok, fixed. http://codereview.appspot.com/110079
