addressed the following comments


http://codereview.appspot.com/116047/diff/1/14
File src/com/google/caja/cajita-module.js (right):

http://codereview.appspot.com/116047/diff/1/14#newcode121
Line 121: r.resolve(cache[mid]);
cache should maintain promises to the module

http://codereview.appspot.com/116047/diff/1/14#newcode135
Line 135: var dependency = resolveDependency(
pass load to resolveDependency

http://codereview.appspot.com/116047/diff/1/14#newcode183
Line 183: }
whether we need this?

http://codereview.appspot.com/116047/diff/1/14#newcode206
Line 206: module, curMid, midResolver, scriptAsyncLoad);
pass the load to resolveDependency

http://codereview.appspot.com/116047/diff/1/16
File src/com/google/caja/parser/quasiliteral/CajitaRewriter.java
(right):

http://codereview.appspot.com/116047/diff/1/16#newcode91
Line 91: private final List<StringLiteral> moduleNameList
it should be a set.

http://codereview.appspot.com/116047/diff/1/16#newcode92
Line 92: = new ArrayList<StringLiteral>();
add a todo of putting this into scope

http://codereview.appspot.com/116047/diff/1/18
File src/com/google/caja/serverjs-sandbox.js (right):

http://codereview.appspot.com/116047/diff/1/18#newcode76
Line 76: };
add id to the cajita load object;
pass the securedmodule to require

http://codereview.appspot.com/116047

Reply via email to