LGTM
http://codereview.appspot.com/157093/diff/1/3 File tests/com/google/caja/plugin/domita_test_untrusted.html (right): http://codereview.appspot.com/157093/diff/1/3#newcode119 tests/com/google/caja/plugin/domita_test_untrusted.html:119: <p>After <code>document.write</code></p> On 2009/11/20 03:21:01, felix8a wrote:
On 2009/11/20 00:37:51, MikeSamuel wrote: > OK. So IE just has different trailing whitespace in the HTML
output. What if
> your normalization was, instead of /[\r\n]\s*/g, something that
trimmed as
well: > /(?:^|[\r\n])\s*|\s+$/g?
it's not just trailing whitespace. there are many different whitespace anomalies in IE's innerHTML output.
I think I'll try normalizing \s+ to a single space. just need to re-test the normalization on all the browsers.
Don't let this stop you from submitting. I only suggested it in case it was a quick fix. The code here isn't testing whitespace handling so I'm fine with the normalization being coarse. http://codereview.appspot.com/157093
