LGTM

http://codereview.appspot.com/157123/diff/1/4
File tests/com/google/caja/plugin/domita_test_untrusted.html (right):

http://codereview.appspot.com/157123/diff/1/4#newcode537
tests/com/google/caja/plugin/domita_test_untrusted.html:537: if
(cssColorString === '"' + expected.name+ '"') { return; }
OK.
Need space before +

http://codereview.appspot.com/157123/diff/1/4#newcode2265
tests/com/google/caja/plugin/domita_test_untrusted.html:2265:
assertComputedStyle(block, null, 'cursor', 'crosshair');
Ok, so you're testing that the style was applied, and so the
cursor:crosshair added in the previous file is a canary.

http://codereview.appspot.com/157123/diff/1/4#newcode2949
tests/com/google/caja/plugin/domita_test_untrusted.html:2949:
assertColor({ name: 'blue', rgb: 0x0000ff }, el.style.borderTopColor);
cool

http://codereview.appspot.com/157123/diff/1/4#newcode3090
tests/com/google/caja/plugin/domita_test_untrusted.html:3090:
assertTrue(new RegExp('Index size error').test(e.message));
cool

http://codereview.appspot.com/157123

Reply via email to