http://codereview.appspot.com/116069/diff/15069/14071 File build.xml (right):
http://codereview.appspot.com/116069/diff/15069/14071#newcode761 build.xml:761: <java failonerror="true" fork="true" classname="com.google.gwt.dev.Compiler"> On 2009/12/03 22:53:27, ihab.awad wrote:
Line wrap (& some other places too)
Done. http://codereview.appspot.com/116069/diff/15069/14071#newcode797 build.xml:797: <replacevalue>${build.svnVersion}</replacevalue> Yes it should. Added. On 2009/12/03 22:53:27, ihab.awad wrote:
Should this task depend on "build.info" then?
http://codereview.appspot.com/116069/diff/15069/14006 File tests/com/google/caja/service/TestHttpServletRequest.java (right): http://codereview.appspot.com/116069/diff/15069/14006#newcode39 tests/com/google/caja/service/TestHttpServletRequest.java:39: import javax.servlet.http.HttpServletRequestWrapper; On 2009/12/03 22:53:27, ihab.awad wrote:
Unused import
Done. http://codereview.appspot.com/116069/diff/15069/14070 File web.xml (right): http://codereview.appspot.com/116069/diff/15069/14070#newcode19 web.xml:19: </servlet> Files in ant-war but outside ant-war/WEB-INF are served statically. On 2009/12/03 22:53:27, ihab.awad wrote:
What serves the static files then?
http://codereview.appspot.com/116069
