On Jul 12, 2010, at 15:49, [email protected] wrote:

Reviewers: ihab.awad,

Description:
Added file caja.js which creates an iframe, then loads everything from
Cajita to HostTools into that frame, and calls a callback with all that
stuff so the host page can load gadgets and grant access to the host
DOM. Changed the container/ demos to use it. Does not update the
playground or any other demos.

I'm not confident that this is "complete", that there isn't something else that should be part of this change; I'm uploading it now because I've been staring at this problem too long and I want some other eyes on the code.

Particularly, this is going to be the direction for future Caja loading except in special circumstances, and I'd appreciate anyone's comments on whether this is a good API design, browser compatibility, etc.

Please review this at http://codereview.appspot.com/1812042/show

Affected files:
 M     build.xml
 D     src/com/google/caja/demos/container/container-dynamic.html
 M     src/com/google/caja/demos/container/container-interaction.html
 M     src/com/google/caja/demos/container/container-trivial.html
 D     src/com/google/caja/demos/container/gadget-library.html
 A  +  src/com/google/caja/demos/container/gadget-library.js
 A     src/com/google/caja/plugin/caja.js
 A     src/com/google/caja/plugin/host-iframe-final.js
 M     src/com/google/caja/plugin/host-tools.js
 A     tests/com/google/caja/plugin/HostIframeTest.java
 A     tests/com/google/caja/plugin/host-iframe-test.html
 A     tests/com/google/caja/plugin/host-iframe-test.js



--
Kevin Reid                                  <http://switchb.org/kpreid/>



Reply via email to