2010/8/9 Chirag <[email protected]>: > I've posted this change on code review: > http://codereview.appspot.com/1945041/show > > Should I be adding [email protected] as a > reviewer? I'm getting the following error. > Delivery to the following recipient failed permanently: > [email protected]
Use [email protected] instead. > On Aug 9, 12:47 pm, Mike Samuel <[email protected]> wrote: >> 2010/8/9 Chirag <[email protected]>: >> >> > I'm running into some issues with escaped HTML entities in my URI. >> > Example: >> > <html><body> >> > <script src="http://example.com/path/?a=1&b=2"> >> > </body></html> >> >> > When Caja's ResolveUriStage resolves the source URL in our script >> > node, the "&" gets rewritten to "&%3b". >> > I have narrowed the issue down to UriUtil#normalizeQuery (correctly) >> > escaping semicolon in query strings. >> >> > Should ResolveUriStage#resolveRelativeUrls be unescaping HTML entities >> > before calling UriUtil.resolve? >> >> Yes. Definitely. And reescaping afterwards. >> >> >> >> > I am able to reproduce this issue using caja-r4209 with Shindig and on >> >http://caja.appspot.com >> >> > Thanks, >> > Chirag
