Re: [Caja] Loosely parsing text "†" as "†" (issue1866052)

[Gagandeep singh]

Took a look at your change, it looks nice :) I just have small comments for
you.


On Thu, Aug 12, 2010 at 9:06 AM, Mike Samuel <mikesam...@gmail.com> wrote:

> http://codereview.appspot.com/1978041/show is a caja patch that does
> do entity fixup for numeric entities and known named entities like
> &amp; and &LT; but not for non-entities like "bar" in <a
> href="?foo=x&bar=y">.
>
> It's also careful not to try to fix entities in CDATA like
> <script>if (lt&gt) { ... }</script>
>
> 2010/8/11  <gagan.g...@gmail.com>:
> > On 2010/08/10 10:02:44, gagan.goku wrote:
> >>
> >> Thanks Anupama, Kuntal for the review.
> >
> >> http://codereview.appspot.com/1866052/diff/26001/27001
> >> File tests/com/google/caja/parser/html/Html5ElementStackTest.java
> >
> > (right):
> >
> >> http://codereview.appspot.com/1866052/diff/26001/27001#newcode91
> >> tests/com/google/caja/parser/html/Html5ElementStackTest.java:91: +
> >
> > "&#xaaaaaaa
> >>
> >> &#123a &#123";
> >> On 2010/08/10 09:58:50, Kuntal Loya wrote:
> >> > expected for &#123a should be &#123a;
> >
> >> I think you meant "&#x123a" (which should be rewritten as "&#x123a;")
> >> &#123a should be rewritten as "&#123;a"
> >
> >> and both of these are consistent with what webkit does.
> >
> > Hi Mike
> >
> > This cl is ready for you to take another look.
> >
> > Thanks
> > Gagan
> >
> > http://codereview.appspot.com/1866052/show
> >
>