Thanks for doing this Paul.

http://codereview.appspot.com/3750046/diff/1/build.xml
File build.xml (right):

http://codereview.appspot.com/3750046/diff/1/build.xml#newcode37
build.xml:37: <project name="caja" default="default" basedir="."
xmlns:artifact="urn:maven-artifact-ant">
Wrap at 80 columns.

http://codereview.appspot.com/3750046/diff/1/build.xml#newcode1629
build.xml:1629: <get src="${maven.ant.tasks.bootstrap.location}"
dest="${maven.ant.tasks.jar}"/>
Can we put the maven utilities jar in third party instead of making
network requests as part of the build?

http://codereview.appspot.com/3750046/diff/1/build.xml#newcode1674
build.xml:1674: description="Signs and Deploys closure-compiler
artifacts to the central maven repo">
s/closure-compiler/caja/

http://codereview.appspot.com/3750046/diff/1/caja-template.pom
File caja-template.pom (right):

http://codereview.appspot.com/3750046/diff/1/caja-template.pom#newcode19
caja-template.pom:19: <groupId>com.google.javascript</groupId>
I do not know the significance of groupId.  Unless there are predefined
groups, com.google.caja might be a better id here.

http://codereview.appspot.com/3750046/

Reply via email to