http://codereview.appspot.com/4530099/diff/13001/src/com/google/caja/es53.js File src/com/google/caja/es53.js (right):
http://codereview.appspot.com/4530099/diff/13001/src/com/google/caja/es53.js#newcode1949 src/com/google/caja/es53.js:1949: id = imports.id___ = +('' + Math.random()).substr(2); Doesn't this change mean that IDs could collide? http://codereview.appspot.com/4530099/diff/13001/src/com/google/caja/plugin/caja.js File src/com/google/caja/plugin/caja.js (right): http://codereview.appspot.com/4530099/diff/13001/src/com/google/caja/plugin/caja.js#newcode292 src/com/google/caja/plugin/caja.js:292: imports.id___ = +('' + Math.random()).substr(2); Why not call ___.getId(imports) to cause an ID to be attached? Also, same question re collisions as with "getId" in es53.js. http://codereview.appspot.com/4530099/diff/13001/src/com/google/caja/plugin/caja.js#newcode304 src/com/google/caja/plugin/caja.js:304: tamingWindow.plugin_dispatchEvent___; I suspect that guestWindow.plugin_* is unused, in which case they should be removed entirely. http://codereview.appspot.com/4530099/diff/13001/src/com/google/caja/plugin/caja.js#newcode305 src/com/google/caja/plugin/caja.js:305: divWindow.plugin_dispatchToHandler___ = Don't we also need a divWindow.plugin_dispatchEvent___ ? http://codereview.appspot.com/4530099/
