http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/parser/quasiliteral/opt/ArrayIndexOptimization.java File src/com/google/caja/parser/quasiliteral/opt/ArrayIndexOptimization.java (right):
http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/parser/quasiliteral/opt/ArrayIndexOptimization.java#newcode111 src/com/google/caja/parser/quasiliteral/opt/ArrayIndexOptimization.java:111: System.err.println("About to optimize: " + render(root, false)); On 2011/06/07 23:05:40, metaweta wrote:
cruft
Done. http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/domita.js File src/com/google/caja/plugin/domita.js (right): http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/domita.js#newcode126 src/com/google/caja/plugin/domita.js:126: function hasGetHandler(object, propertyName) { On 2011/06/07 23:05:40, metaweta wrote:
You want this code: return !!this[name + '_getter___'];
Actually _g___, done. http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/domita.js#newcode131 src/com/google/caja/plugin/domita.js:131: function hasSetHandler(object, propertyName) { On 2011/06/07 23:05:40, metaweta wrote:
You want code similar to above, but using _setter___.
Actually _s___, done. http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/domita.js#newcode136 src/com/google/caja/plugin/domita.js:136: function hasCallHandler(object, propertyName) { On 2011/06/07 23:05:40, metaweta wrote:
Ditto, _handler___
Unused function, removed. http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/domita.js#newcode141 src/com/google/caja/plugin/domita.js:141: function hasDeleteHandler(object, propertyName) { On 2011/06/07 23:05:40, metaweta wrote:
Ditto, _deleter___
Unused function, removed. http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/domita.js#newcode266 src/com/google/caja/plugin/domita.js:266: this[name + '_e___'] = true; On 2011/06/07 23:05:40, metaweta wrote:
Should be this[name + '_e___'] = this;
Done. http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/domita.js#newcode272 src/com/google/caja/plugin/domita.js:272: if (___.isFrozen(this)) { throw new Error(FROZEN); } On 2011/06/07 23:05:40, metaweta wrote:
Object.isFrozen
Done. http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/domita.js#newcode1814 src/com/google/caja/plugin/domita.js:1814: this[name + '_e___'] = true; On 2011/06/07 23:05:40, metaweta wrote:
again, set to this, not true
Done. http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/domita.js#newcode2008 src/com/google/caja/plugin/domita.js:2008: this[name + '_e___'] = true; On 2011/06/07 23:05:40, metaweta wrote:
again
Done. http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/domita.js#newcode3707 src/com/google/caja/plugin/domita.js:3707: this[name + '_e___'] = true; On 2011/06/07 23:05:40, metaweta wrote:
again
Done. http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/domita.js#newcode4347 src/com/google/caja/plugin/domita.js:4347: href: String(optPseudoWindowLocation.href || 'http://nosuchhost.fake:80/'), On 2011/06/07 23:05:40, metaweta wrote:
line length
Done. http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/domita.js#newcode4548 src/com/google/caja/plugin/domita.js:4548: this[name + '_e___'] = true; On 2011/06/07 23:05:40, metaweta wrote:
again
Done. http://codereview.appspot.com/4515107/diff/17022/tests/com/google/caja/plugin/browser-test-case.js File tests/com/google/caja/plugin/browser-test-case.js (right): http://codereview.appspot.com/4515107/diff/17022/tests/com/google/caja/plugin/browser-test-case.js#newcode422 tests/com/google/caja/plugin/browser-test-case.js:422: standardImports.assertColor = frameGroup.tame(frameGroup.markFunction(function(expected, cssColorString) { On 2011/06/07 23:05:40, metaweta wrote:
line length
Done. http://codereview.appspot.com/4515107/diff/17022/tests/com/google/caja/plugin/es53-test-domita-canvas-guest.html File tests/com/google/caja/plugin/es53-test-domita-canvas-guest.html (right): http://codereview.appspot.com/4515107/diff/17022/tests/com/google/caja/plugin/es53-test-domita-canvas-guest.html#newcode52 tests/com/google/caja/plugin/es53-test-domita-canvas-guest.html:52: assertUndefined('getContext with unapproved contextId', canvas.getContext("foo")); On 2011/06/07 23:05:40, metaweta wrote:
Line length (and several more below)
Done. http://codereview.appspot.com/4515107/diff/17022/tests/com/google/caja/plugin/es53-test-domita-dom-guest.html File tests/com/google/caja/plugin/es53-test-domita-dom-guest.html (right): http://codereview.appspot.com/4515107/diff/17022/tests/com/google/caja/plugin/es53-test-domita-dom-guest.html#newcode92 tests/com/google/caja/plugin/es53-test-domita-dom-guest.html:92: // TODO(mikesamuel): enable for all node-types once EQ fixed on IE On 2011/06/07 23:05:40, metaweta wrote:
Annoying line lengths
Done. http://codereview.appspot.com/4515107/
